Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change / to // (integer division) in several places #10

Merged

Conversation

msabramo
Copy link
Contributor

This fixes a bunch of bugs and test failures in Python 3, which uses "true division" for /

This fixes a bunch of bugs and test failures in Python 3, which uses
"true division" for /
@Byron
Copy link
Member

Byron commented Jun 16, 2014

Hi Marc,

Please have the keys to my house, and feel right at home - you now have write access to this repository. Therefore, you can merge this pull-request yourself.

Cheers,
Sebastian

@msabramo
Copy link
Contributor Author

Thanks, @Byron! I'd love for you to still review things even if I merge them. I don't want to mess up your house or the neighborhood!

msabramo added a commit that referenced this pull request Jun 16, 2014
Change / to // (integer division) in several places
@msabramo msabramo merged commit 75bf210 into gitpython-developers:master Jun 16, 2014
@msabramo msabramo deleted the use_integer_division_for_py3 branch June 16, 2014 13:29
@Byron
Copy link
Member

Byron commented Jun 16, 2014

Thanks for being responsible :) !
Fortunately, a 93% in test coverage means that my pal Travis will do most of the work in detecting new bugs anyway. Of course, he's not perfect, but should flag the most obvious mistakes.

After all these years of me not looking at smmap, I suppose he is better than I am in maintaining quality.

Nonetheless, if the changes are less trivial, I will be inclined to take a thorough look as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants