Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote gitolite #19

Merged
merged 1 commit into from Dec 18, 2011
Merged

promote gitolite #19

merged 1 commit into from Dec 18, 2011

Conversation

hemmecke
Copy link

No description provided.

@ngulden
Copy link

ngulden commented Oct 25, 2011

Hello hemmecke,

I suggest you add the date for your update to the text of your pull request. That makes it clear to reader within the text when the update has been added. After that I would be happy to accept your pull request.

Best regards,
ngulden

@hemmecke
Copy link
Author

I would like that my two commits were squashed together. I could have amended my first commit, but I didn't know how github will handle this and whether I should better then open up a new pull request. So if you also just like one commit, tell me how I should prepare it "in the github way".

@joliss
Copy link
Member

joliss commented Oct 28, 2011

I'm not the repo maintainer, but you can in fact just squash them (git rebase --interactive origin, or HEAD~2), do a git push -f, and GitHub will automatically update this pull request.

@ngulden
Copy link

ngulden commented Nov 15, 2011

Well, I think it's ok to have those two commits. That's what code reviews are for, aren't they ;-)?

@hemmecke: If you are fine with it, I would just accept your merge. I'm looking forward to your response.

@hemmecke
Copy link
Author

Hi ngulden, you've just hit me in the right moment. I've squashed the two commits.

qrush added a commit that referenced this pull request Dec 18, 2011
@qrush qrush merged commit ef3df7f into gitready:en Dec 18, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants