Browse files

remote-testgit: implement the "done" feature manually

People who want to write their own remote-helper will find it more
useful to see clearly how they are supposed to advertise and implement
the "done" feature themselves.

Right now we are relying on fast-export to do that by using the
--use-done-feature argument. However, people writing their own
remote-helper would probably not have such an option, as they would
probably be writing the fast-export functionality themselves.

It should now be clearer to them.

Signed-off-by: Felipe Contreras <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent 93b5cf9 commit 1d3f9a30938e12b8ef7b807df7565b40b743d421 @felipec felipec committed with Nov 28, 2012
Showing with 3 additions and 1 deletion.
  1. +3 −1 git-remote-testgit
@@ -61,8 +61,10 @@ do
echo "feature import-marks=$gitmarks"
echo "feature export-marks=$gitmarks"
- git fast-export --use-done-feature "${testgitmarks_args[@]}" $refs |
+ echo "feature done"
+ git fast-export "${testgitmarks_args[@]}" $refs |
sed -e "s#refs/heads/#${prefix}/heads/#g"
+ echo "done"
before=$(git for-each-ref --format='%(refname) %(objectname)')

0 comments on commit 1d3f9a3

Please sign in to comment.