Skip to content

Commit

Permalink
vcs-svn: drop no-op reset methods
Browse files Browse the repository at this point in the history
Since v1.7.5~42^2~6 (vcs-svn: remove buffer_read_string)
buffer_reset() does nothing thus fast_export_reset() also.

Signed-off-by: David Barr <davidbarr@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
  • Loading branch information
barrbrain authored and jrn committed Jul 6, 2012
1 parent 5b8bf02 commit 3b8a305
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 16 deletions.
1 change: 0 additions & 1 deletion test-line-buffer.c
Expand Up @@ -87,6 +87,5 @@ int main(int argc, char *argv[])
die("input error");
if (ferror(stdout))
die("output error");
buffer_reset(&stdin_buf);
return 0;
}
2 changes: 0 additions & 2 deletions test-svn-fe.c
Expand Up @@ -31,9 +31,7 @@ static int apply_delta(int argc, char *argv[])
die_errno("cannot close preimage");
if (buffer_deinit(&delta))
die_errno("cannot close delta");
buffer_reset(&preimage);
strbuf_release(&preimage_view.buf);
buffer_reset(&delta);
return 0;
}

Expand Down
5 changes: 0 additions & 5 deletions vcs-svn/fast_export.c
Expand Up @@ -42,11 +42,6 @@ void fast_export_deinit(void)
die_errno("error closing fast-import feedback stream");
}

void fast_export_reset(void)
{
buffer_reset(&report_buffer);
}

void fast_export_delete(const char *path)
{
putchar('D');
Expand Down
1 change: 0 additions & 1 deletion vcs-svn/fast_export.h
Expand Up @@ -6,7 +6,6 @@ struct line_buffer;

void fast_export_init(int fd);
void fast_export_deinit(void);
void fast_export_reset(void);

void fast_export_delete(const char *path);
void fast_export_modify(const char *path, uint32_t mode, const char *dataref);
Expand Down
4 changes: 0 additions & 4 deletions vcs-svn/line_buffer.c
Expand Up @@ -124,7 +124,3 @@ off_t buffer_skip_bytes(struct line_buffer *buf, off_t nbytes)
}
return done;
}

void buffer_reset(struct line_buffer *buf)
{
}
1 change: 0 additions & 1 deletion vcs-svn/line_buffer.h
Expand Up @@ -14,7 +14,6 @@ struct line_buffer {
int buffer_init(struct line_buffer *buf, const char *filename);
int buffer_fdinit(struct line_buffer *buf, int fd);
int buffer_deinit(struct line_buffer *buf);
void buffer_reset(struct line_buffer *buf);

int buffer_tmpfile_init(struct line_buffer *buf);
FILE *buffer_tmpfile_rewind(struct line_buffer *buf); /* prepare to write. */
Expand Down
2 changes: 0 additions & 2 deletions vcs-svn/svndump.c
Expand Up @@ -499,8 +499,6 @@ void svndump_deinit(void)

void svndump_reset(void)
{
fast_export_reset();
buffer_reset(&input);
strbuf_release(&dump_ctx.uuid);
strbuf_release(&dump_ctx.url);
strbuf_release(&rev_ctx.log);
Expand Down

0 comments on commit 3b8a305

Please sign in to comment.