Skip to content

Commit

Permalink
Merge branch 'ss/fix-config-fd-leak'
Browse files Browse the repository at this point in the history
* ss/fix-config-fd-leak:
  config: close config file handle in case of error
  • Loading branch information
gitster committed Aug 26, 2015
2 parents 33f2c4f + 54d160e commit 51e83a4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion config.c
Expand Up @@ -1935,7 +1935,7 @@ int git_config_set_multivar_in_file(const char *config_filename,
const char *key, const char *value,
const char *value_regex, int multi_replace)
{
int fd = -1, in_fd;
int fd = -1, in_fd = -1;
int ret;
struct lock_file *lock = NULL;
char *filename_buf = NULL;
Expand Down Expand Up @@ -2065,6 +2065,7 @@ int git_config_set_multivar_in_file(const char *config_filename,
goto out_free;
}
close(in_fd);
in_fd = -1;

if (chmod(get_lock_file_path(lock), st.st_mode & 07777) < 0) {
error("chmod on %s failed: %s",
Expand Down Expand Up @@ -2148,6 +2149,8 @@ int git_config_set_multivar_in_file(const char *config_filename,
free(filename_buf);
if (contents)
munmap(contents, contents_sz);
if (in_fd >= 0)
close(in_fd);
return ret;

write_err_out:
Expand Down

0 comments on commit 51e83a4

Please sign in to comment.