Skip to content

Commit

Permalink
t1003-read-tree-prefix.sh: use the $( ... ) construct for command sub…
Browse files Browse the repository at this point in the history
…stitution

The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
devzero2000 authored and gitster committed Apr 29, 2014
1 parent 9b3bc87 commit 7f311eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion t/t1003-read-tree-prefix.sh
Expand Up @@ -11,7 +11,7 @@ test_description='git read-tree --prefix test.
test_expect_success setup '
echo hello >one &&
git update-index --add one &&
tree=`git write-tree` &&
tree=$(git write-tree) &&
echo tree is $tree
'

Expand Down

0 comments on commit 7f311eb

Please sign in to comment.