Skip to content

Commit

Permalink
use strbuf_addbuf() for appending a strbuf to another
Browse files Browse the repository at this point in the history
Use strbuf_addbuf() where possible; it's shorter and more efficient.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
rscharfe authored and gitster committed Jul 19, 2016
1 parent e465796 commit 8109984
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dir.c
Expand Up @@ -2346,7 +2346,7 @@ void write_untracked_extension(struct strbuf *out, struct untracked_cache *untra

varint_len = encode_varint(untracked->ident.len, varbuf);
strbuf_add(out, varbuf, varint_len);
strbuf_add(out, untracked->ident.buf, untracked->ident.len);
strbuf_addbuf(out, &untracked->ident);

strbuf_add(out, ouc, ouc_size(len));
free(ouc);
Expand Down
2 changes: 1 addition & 1 deletion path.c
Expand Up @@ -246,7 +246,7 @@ static void do_submodule_path(struct strbuf *buf, const char *path,
strbuf_addstr(buf, git_dir);
}
strbuf_addch(buf, '/');
strbuf_addstr(&git_submodule_dir, buf->buf);
strbuf_addbuf(&git_submodule_dir, buf);

strbuf_vaddf(buf, fmt, args);

Expand Down
2 changes: 1 addition & 1 deletion wt-status.c
Expand Up @@ -1060,7 +1060,7 @@ static void abbrev_sha1_in_line(struct strbuf *line)
strbuf_addf(split[1], "%s ", abbrev);
strbuf_reset(line);
for (i = 0; split[i]; i++)
strbuf_addf(line, "%s", split[i]->buf);
strbuf_addbuf(line, split[i]);
}
}
for (i = 0; split[i]; i++)
Expand Down

0 comments on commit 8109984

Please sign in to comment.