issues/commit to be links, not spans

[trevorah]

The problems that I want to solve are these:

• you cant write markdown for a link to a commit that has the text of a commit message but is also decorated like a commit. I.e you cant write the "pushed commits to github" commits in the activity feed in markdown.
• we're converting all our span issues to links on the client, which is just silly.

Id also like to turn all @mentions into links as well (wdyt @lerouxb?)
Id like to also add a githubContext option to the processor, so that we stop decorating #1 as an issue if you are not in a repo room or sub channel. That make our issue decoration much more reliable.

opinions please @suprememoocow @lerouxb

(btw there are examples committed as tests)

[lerouxb]

Yes please. Make these things links so you can still open them in a new tab without having to go through the popup. It should also make Tim Berners-Lee proud. And if things ever fail then you can at least still click the link.

[trevorah]

@lerouxb and the usernames?

[lerouxb]

I think everything linkable (or that started off as links) should be links, not spans. But usernames are now tricky because they aren't all github usernames, so where do you link the non-gh ones..

[trevorah]

well, cant we just link them to https://gitter.im/username?

[lerouxb]

Sure, but that URL tends to do nothing.. Or do you mean only the non-gh ones?

[trevorah]

I guess we can keep them as spans. When someone types @username, they do it to get someones attention, very rarely is it used for referencing someone.

[lerouxb]

Yeah. It wasn't like the person pasted a link, unlike with commits or issues or pull requests and things. Once we have profile pages and more social network type features we can rethink it.