Skip to content
This repository has been archived by the owner on Sep 5, 2018. It is now read-only.

Do not override "Array.from" with shim version if it is available. #68

Merged
merged 1 commit into from Feb 4, 2018
Merged

Do not override "Array.from" with shim version if it is available. #68

merged 1 commit into from Feb 4, 2018

Conversation

Viatorus
Copy link
Contributor

@Viatorus Viatorus commented Jan 13, 2018

Because the following code does not work with the "Array.from" version of shim:

Array.from(new Set([1, 2, 3]))

Expected behavior
[1, 2, 3]

Actual behavior
[]

@MadLittleMods
Copy link
Member

MadLittleMods commented Feb 4, 2018

@Viatorus Sorry for the delay. Change looks good 👍 although I think this is already covered in the shim, https://github.com/mathiasbynens/Array.from/blob/25120ee20f774034c2bc7a290c3a9bd0b073d833/shim.js#L11 (reverted this for now, #69)

Does this cause any actual errors in our code for browsers that use the shim? I don't see any usage of Set in our code.

@Viatorus
Copy link
Contributor Author

Viatorus commented Feb 7, 2018

@MadLittleMods
Thank you.

You don't use Set but I use it and it alters the behavior of my scripts (used with mkDocs/readthedocs).

MadLittleMods added a commit that referenced this pull request Feb 13, 2018
…ay_from_polyfill

Do not override "Array.from" with shim version if it is available.

See #68
@MadLittleMods
Copy link
Member

MadLittleMods commented Feb 13, 2018

Thanks for the clarification @Viatorus 🙂 - I'll re-merge this! (via #70)

Now published in gitter-sidecar@1.3.3 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants