Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings to auto initialize non-git repository #3596

Merged
merged 5 commits into from Dec 20, 2019

Conversation

mittalyashu
Copy link
Member

This PR added the option in the Settings page of the app allowing users to toggle (on/off) this feature.

This feature automatically initializes git inside a non-git repository.

Using if/else statement in beforeCreate lifecycle hook insted of using in vuex store mutation
@mittalyashu mittalyashu self-assigned this Dec 15, 2019
@mittalyashu mittalyashu added this to the 0.1.0 milestone Dec 15, 2019
@mittalyashu mittalyashu added this to To do in Roadmap via automation Dec 15, 2019
@mittalyashu mittalyashu added difficulty: easy Front end Git Git related stuff git commit... labels Dec 15, 2019
@mittalyashu
Copy link
Member Author

Though, this PR is incomplete, I am still merging it with chore/add-nodegit branch, since some of the code is merged from #3592.

@mittalyashu mittalyashu moved this from To do to In progress in Roadmap Dec 20, 2019
@mittalyashu mittalyashu merged commit 55d712c into chore/add-nodegit Dec 20, 2019
Roadmap automation moved this from In progress to Done Dec 20, 2019
@mittalyashu mittalyashu deleted the feat/git-auto-init-repository branch December 20, 2019 16:52
mittalyashu added a commit that referenced this pull request Jun 5, 2021
* Initialize Git repository (nodegit) (#3509)

* Install NodeGit package

* Fix nodegit package installation (#3512)

* Change node_version to 10.16.0

* Define node & electron engines in package.json

* FIX: Add comma after node version engine

* Switch back to latest version of Node@10

* Split script command yarn and yarn build:window

* Update "postinstall" script command to install electron app deps

* Install electron app native deps

* Merge yarn && yarn postinstall && yarn build:linux command

* Test windows pipeline with npm

* Upgrade nodegit & electron-builder package

* Run pipeline in npm

* Run audit fix

* Run install && audit fix

* install & audit fix & postinstall & build:window

* Update build description

* Move yarn to npm

* Update echo command

* Remove electron from engines

* Update npm registry url

* Initialize repo using nodegit

* Use promise instead of async

* git status (nodegit)

* fix: switchRepository mutation to toggle modal

* Remove remote refs & validate git repository

Remove function for getting remote url on adding repository and only validate git repository.

* Add getBranchName function using nodegit

* Add source column to db table

Source column tells the source of repository (local or remote repo)

* git status and get file status type

Getting repository git status along with each file type, symbol, and color.

* Query repository data on route (enter & update)

* Clear repositoryData on routeLeave

* Update projectId to repositoryId (route params)

* Add repositoryData state, getters, and mutation

* Show branch name and working changes

* Move to next page after database data

* Show staged files in workspace

* Query repository & repositorySettings features data

* Remove refs from workspace

* Move to status-list component

Remove fileChangesSkeleton and use status-list component

* Create status item component

* Remove branchName parmas from workspace route

* Pass branchName as props to commit-message

* NodeGit + SQLite migration : implement clone feature (#3589)

* Use nodegit

* Use database

* Add cloning progress

* Run ESLint

* Remove workspace vuex store

* Emit stagedFile to statusList component

Storing all the statusList component inside stagedFile local data property.

* Change projectId to repositoryId

Repository ID is unique ID assigned to each repository from SQLite database.

* Show repo path in switch repo modal

* Set default branchName to "master"

* Remove getFeatureValue computed property

* Get repository data using mixin

Using repositoryData.js as mixin to get data from repository.js vuex store as repositoryData computed property.

* Git remote functions

Add these 3 remote functions

* getRemoteListNames
* getRemoteUrl
* addRemoteUrl

* Remove branchName as route props

* Query remoteUrl from db

Fetch remote url from database on entering repository route

* Save remote url to db on adding repository

* Update add remote url with nodegit

* store filePreview value locally data property

filePreview is a local data property stored in `workspace.vue` to toggle view for diff preview component with blankSlate component

* adjust workspace files width

* Remove file diff preview method

* refactor: remove unused code

* Remove spacingProps, import repositoryData

* Update repositoryData computed property data

* Update to repositoryId & remove branchName params

* Remove event.preventDefault()

* Remove repositoryDataMixin import from settings.vue

* Update remoteUrl on saveSettings method

Update remoteUrl to database on running the saveSettings() method

* Git fetch functions

* pullRemoteBranch function

* Add gitFetch method to navbar

* Update directoryPath arguments (openTerminal & openFileExplorer)

* Update gitPull method with nodegit

* Remove branchName as route params

* Update repositoryData import

* Toggle commit-message component in workspace view

* Query repositoryName on enter repository route

* Change Git module to Clone in clone.js

* Remove console statement

* Format the code

* Update openCmdTerminal() method

* Initialize repository (nodegit) (#3592)

* Use nodegit and database instead of simple-git for initialize repository feature

* Disable git features for non-initialized repositories

* Add initialize repository feature from homepage

This commit includes an anti-pattern because of mutating this.isGit prop inside component but this can't be avoided without making some major changes.

* Settings to auto initialize non-git repository (#3596)

* Get & set settings to localStorage

Using if/else statement in beforeCreate lifecycle hook insted of using in vuex store mutation

* Add AutoInit settings to experimental page

* typo: initialize spellings

* Dispatch update to settings store (in single line)

* fix: autoInit undefined value in settings store

#3596 (comment)

* Remove console.log statement in setSettings

* Fix PR #3598 : Auto init non-git repository (part 2) (#3599)

* auto initialize non-git repository

* Update repositoryItem.vue after `npm run lint:fix`

* Do not initialize new repository on create

* Fix blocking error on new repository creation when folder does not exist

Co-authored-by: Yashu Mittal <mittalyashu77@gmail.com>

* addRepositoryToDatabase based closing modal

Incase error event a message can be shown inside the modal.

Reference: #3599 (comment)

* update isGit value in repository store

Creating a updateIsGitStatus mutation to update isGit value inside repository vuex store.

Database is updated with the required changes with vuex is unaware of the changes which causes is bug to show repository as `isGit: false`.

Reference: #3599 (comment)

* Update .electron-vue files

replace package-lock.json with yarn.lock

* change node engine v14

* ci: run pipeline with node v14 & v16

* ci: change npm to yarn

* set node engine v14 or v16

* ci: yarn postinstall deps

Co-authored-by: KaKi87 <tiana.lemesle@live.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy Front end Git Git related stuff git commit...
Projects
Roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant