policy: Verify new policy against previous policy #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinCappos
approved these changes
Sep 16, 2023
wlynch
approved these changes
Oct 2, 2023
Signed-off-by: Aditya Sirish <aditya@saky.in>
adityasaky
force-pushed
the
verify-new-policy-root
branch
from
234d32c
to
906e1e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we were verifying each policy state internally. We weren't verifying that a new policy's root role is signed by keys trusted in the previous policy's root. This adds that check, and in the process, I think we solve the issue of not verifying RSL entry signatures for policy changes.