Use rewritten gitinterface #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
4 times, most recently
from
79a70eb
to
3df82ce
Compare
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
from
3df82ce
to
b7f9012
Compare
|
work pending on some fixes as the other gitinterface PRs changed. However, this is close to ready, I think. Note: there's a pretty gnarly rise in time required for tests in policy, repository, rsl packages. 😬 |
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
2 times, most recently
from
c8bbc58
to
9cec063
Compare
This was referenced Jun 13, 2024
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
3 times, most recently
from
c1cfa71
to
ab1fa83
Compare
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
from
ab1fa83
to
23b23e6
Compare
|
Interestingly, the linter didn't complain about the err message strings in #445. I've got that in here. |
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
from
23b23e6
to
285c1f3
Compare
Merged
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
3 times, most recently
from
e3758c2
to
70bab18
Compare
1 task
wlynch
reviewed
Jun 20, 2024
1 task
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
2 times, most recently
from
5122aec
to
9c16e4c
Compare
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
from
9c16e4c
to
1b3ab83
Compare
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
from
1b3ab83
to
863296f
Compare
neilnaveen
reviewed
Jun 20, 2024
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
from
863296f
to
bf1ef03
Compare
wlynch
requested changes
Jun 21, 2024
Signed-off-by: Aditya Sirish <aditya@saky.in>
Signed-off-by: Aditya Sirish <aditya@saky.in>
Signed-off-by: Aditya Sirish A Yelgundhalli <ayelgundhall@bloomberg.net>
Signed-off-by: Aditya Sirish A Yelgundhalli <ayelgundhall@bloomberg.net>
adityasaky
force-pushed
the
use-rewritten-gitinterface
branch
from
bf1ef03
to
a6f75c0
Compare
wlynch
approved these changes
Jun 21, 2024
patzielinski
approved these changes
Jun 21, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complementary to #367