Added t2083 - error messages for missing newlines.

src/tup/parser.c

@@ -295,8 +295,10 @@ static int parse_tupfile(struct tupfile *tf, struct buf *b, tupid_t curdir,
 
 		line = p;
 		newline = strchr(p, '\n');
-		if(!newline)
+		if(!newline) {
+			fprintf(stderr, "tup error: Missing newline character.\n");
 			goto syntax_error;
+		}
 		lno++;
 		while(newline[-1] == '\\' || (newline[-2] == '\\' && newline[-1] == '\r')) {
 			if (newline[-1] == '\r') {
@@ -305,8 +307,10 @@ static int parse_tupfile(struct tupfile *tf, struct buf *b, tupid_t curdir,
 			newline[-1] = ' ';
 			newline[0] = ' ';
 			newline = strchr(p, '\n');
-			if(!newline)
+			if(!newline) {
+				fprintf(stderr, "tup error: Missing newline character.\n");
 				goto syntax_error;
+			}
 			lno++;
 		}
 

test/t2083-missing-newline.sh

@@ -0,0 +1,41 @@
+#! /bin/sh -e
+
+# Tup should parse correctly if the last newline is missing.
+
+. ./tup.sh
+
+cat > ok.c << HERE
+#include <stdio.h>
+
+int main(void)
+{
+	printf(": foreach *.c |> gcc -c %%f -o %%o |> %%B.o");
+	return 0;
+}
+HERE
+gcc ok.c -o ok
+./ok > Tupfile
+
+tup touch Tupfile ok.c ok
+parse_fail_msg "Missing newline character"
+
+cat > ok.c << HERE
+#include <stdio.h>
+
+int main(void)
+{
+	/* The six backslashes here becomes 3 in the C program, 2 of which
+	 * become a backslash in the Tupfile, and 1 of which is used with
+	 * the newline.
+	 */
+	printf(": foreach *.c |> \\\\\\ngcc -c %%f -o %%o |> %%B.o");
+	return 0;
+}
+HERE
+gcc ok.c -o ok
+./ok > Tupfile
+
+tup touch Tupfile
+parse_fail_msg "Missing newline character"
+
+eotup