-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph seemingly disconnected when it shouldn't be #17
Comments
I've seen it happen too. I think it's caused a rebase (which changes commit-dates), which I think confuses our lane-builder. I've also seen a degenerate case where (in your example) you'd get only the 3 leftmost-lane commits, and the rest would be gone, but I think it's when the branch is filtered. |
Bisecting it, it looks like it's broken since 71b598b |
That 71b598b commit is me trying to fix some other issue there was with the code "the other way around". It seems this instance of the bug can be traced back to the switch to IIRC I was trying to fix an issue where sometime, the topological sort starts with unrelated, old branches instead of recently-changed ones, which makes for a messy graph. Having it time-sorted fix that issues, but it can confuse the lane grapher, hence this issue. See #19 for a (WIP) tentative fix. |
While investigating gitx#17, I found that code pretty hard to understand. For the record, it built a set of OIDs while extracting the meaning of the `PBGitRevSpecifier`, which (since sets have no order) I suspected could cause the out-of-order behavior we had. Turns out the fix was much easier, but since I find this one cleaner, and less "loopy", here it is.
I start in this state:
When I
git checkout 1d4e8c1
, GitX suddenly shows me in a strange disconnected state:This is built against commit SHA
8b1aa1562504d182130e94f31dda2ee07d10a649
. I'd be happy to step in Xcode and test out theories against this repo, if you have any.The text was updated successfully, but these errors were encountered: