Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the stash/discard/copy buttons #9

Closed
tiennou opened this issue Dec 20, 2016 · 2 comments · Fixed by #10
Closed

Fix the stash/discard/copy buttons #9

tiennou opened this issue Dec 20, 2016 · 2 comments · Fixed by #10

Comments

@tiennou
Copy link
Contributor

tiennou commented Dec 20, 2016

This

capture d ecran 2016-12-20 10 04 00

makes me nervous.

I know I'll misclick once, and lose stuff. I know.

Propostions :

  • Standardize on an ordering. Easy to do, but breaks muscle memory.
  • Remove Copy, and make it go through the responder chain, as it should have. Harder, esp. w.r.t the state of the chain, but less UI clutter, and misclick chance gets NULLed.
@ssp
Copy link
Contributor

ssp commented Dec 22, 2016

As the Discard Button will ask for confirmation before destroying your work, you probably won’t lose stuff all that easily :)

Yet I totally agree with your point that a standardised ordering will definitely make a better UI.

I totally like the idea of moving the copy command and reducing the clutter (but at this point I am not familiar enough with GitX’s WebKit integration to know how to make this work).

@nanotech
Copy link
Contributor

Yeah, keeping the order consistent is much better. I noticed this too while I was restyling but didn't get to looking closer at it.

I just created #11 which connects copying to the responder chain. WebView has some APIs that make it pretty easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants