Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error msg not helpfull #17

Closed
Tracked by #19
leonsgithub opened this issue Oct 4, 2016 · 2 comments
Closed
Tracked by #19

Error msg not helpfull #17

leonsgithub opened this issue Oct 4, 2016 · 2 comments

Comments

@leonsgithub
Copy link

leonsgithub commented Oct 4, 2016 •
edited
Loading

In duka/duka/core/utils.py
the error message for the candle timeframe is
'duka: error: argument -c/--candle: Not a valid time frame: '5M'. '

but the help (duka -h)

-c CANDLE, --candle CANDLE
use candles instead of ticks. Accepted values 1M 5M
10M 15M 30M 1H 4H

That is confusing until you read the code and see that it should be M5

in main.py
help='use candles instead of ticks. Accepted values M1 M5 M10 M15 M30 H1 H4',
@giuse88
Copy link
Owner

giuse88 commented Oct 4, 2016

Thanks for spotting this problem. I am going to fix it. 👍

giuse88 added a commit that referenced this issue Nov 27, 2016
@giuse88
Fix candles help string issue #17
6b293cb
This was referenced Nov 27, 2016
Open
Closed
@giuse88
Copy link
Owner

giuse88 commented Nov 27, 2016

Fixed in #19

@giuse88 giuse88 closed this as completed Dec 4, 2016
thomasf1 added a commit to thomasf1/duka that referenced this issue Dec 10, 2019
@thomasf1
Merge commit 'b2a20917101bc94a31d21047db130eb92e5b9787'
f0c3807 
* commit 'b2a20917101bc94a31d21047db130eb92e5b9787':
  Add timezone info to the file name.
  Fix variable name
  Update Help message
  Added travis
  Fix unit tests
  Add local time Fix giuse88#18
  Fix candles help string issue giuse88#17

# Conflicts:
#	.travis.yml
#	README.md
#	duka/app/app.py
#	duka/core/csv_dumper.py
#	duka/core/processor.py
#	duka/main.py
#	requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giuse88 @leonsgithub