Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use this.attributes #6

Closed
simonsmith opened this issue Sep 23, 2014 · 2 comments · Fixed by #8
Closed

Use this.attributes #6

simonsmith opened this issue Sep 23, 2014 · 2 comments · Fixed by #8

Comments

@simonsmith
Copy link

this.defaultAttrs is deprecated since 1.2.0
@giuseppeg
Copy link
Owner

+1 I was waiting for the CommonJS migration to fix this too.

@simonsmith
Copy link
Author

Ah nice 👍
Yeah, using Webpack to get round the AMD only side at the moment.

giuseppeg added a commit that referenced this issue Nov 2, 2014
@giuseppeg
v1.0.0
1064d7a 
Fixes #5
Fixes #6
Fixes #7
Add tests
giuseppeg added a commit that referenced this issue Nov 2, 2014
@giuseppeg
v1.0.0
0435f27 
Fixes #5
Fixes #6
Fixes #7
Add tests
@giuseppeg giuseppeg mentioned this issue Nov 2, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.0.0 giuseppeg/flight-request
2 participants
@simonsmith @giuseppeg