Fix sync problem #35
Merged
Fix sync problem #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppeg
reviewed
Sep 3, 2020
| @@ -15,7 +15,8 @@ describe('styled-jsx-plugin-postcss', () => { | |||
|
|
|||
| it('works with placeholders', () => { | |||
| assert.equal( | |||
| plugin('p { color: %%styled-jsx-placeholder-0%%; & img { display: block; } } %%styled-jsx-placeholder-1%%'), 'p { color: %%styled-jsx-placeholder-0%% } p img { display: block; } %%styled-jsx-placeholder-1%%' | |||
| plugin('p { color: %%styled-jsx-placeholder-0%%; & img { display: block; } } %%styled-jsx-placeholder-1%%') | |||
There was a problem hiding this comment.
we should add a test where the css has quotes and other characters that could be problematic when stringifying to JSON
giuseppeg
reviewed
Sep 5, 2020
index.js
Outdated
| settingsArg = JSON.stringify(settings).replace(/\"/g,`\\"`) | ||
| const result = childProcess.execSync(`node ${__dirname}/processor.js "${cssWithPlaceholdersArg}" "${settingsArg}"`, | ||
| { encoding: 'utf8', maxBuffer: 50 * 1024 * 1024 }) | ||
| const result = execSync(`node ${path.resolve(__dirname, "processor.js")}`, { |
There was a problem hiding this comment.
nit you can use
spawnSync(path.resolve(__dirname, "processor.js"), options)
Closed
|
@tldrd0117 awesome thank you a lot for this contribution! I released this changes as 3.0.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used execSync