Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus on all links off index.html show same error #122

Open
Twilight-Computer opened this issue Apr 29, 2024 · 5 comments
Open

Menus on all links off index.html show same error #122

Twilight-Computer opened this issue Apr 29, 2024 · 5 comments

Comments

@Twilight-Computer
Copy link

Since a few days now, all pages linked off index.htm (eg About / Services etc) all show:

Warning: Undefined variable $generate_menu in /var/www/html/twilight/storage/compiled-templates/app_1_landing_about.html on line 233

I have checked permissions on the the storage folder and even deleted all files, but the same error occurs - suggestions ?

@givanz
Copy link
Owner

givanz commented Apr 29, 2024

Can you please provide more details.

This is showing after page cache refresh or only when logged in the admin area?

I checked about/services page on your site and the error is gone.

@Twilight-Computer
Copy link
Author

Twilight-Computer commented Apr 29, 2024 via email

@givanz
Copy link
Owner

givanz commented Apr 29, 2024

I see the error now.

This is caused by a missing submenu element in the first menu item and it seems to be caused by a bug in the menu component on page save.

To fix it please restore /public/themes/landing/blank.html and clear cache.

I will try to reproduce the missing submenu element on page save.

Thanks for the bug report.

@Twilight-Computer
Copy link
Author

Twilight-Computer commented Apr 30, 2024 via email

@givanz
Copy link
Owner

givanz commented May 2, 2024

The menu from all pages except homepage are linked using data-v-save-global attribute, the menu content is loaded and saved to blank.html on any menu change.

I'm unable to reproduce this bug, it is caused by missing submenu on the first menu when saving but I'm unable to make it break to find the cause.

This might be an old bug or something specific to your setup.

If it still doesn't work after update you can provide me temporary access and I can investigate the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants