Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Save HTML from designer with PGSQL on windows #93

Open
jeromeatneotek opened this issue Feb 28, 2024 · 7 comments
Open

Cannot Save HTML from designer with PGSQL on windows #93

jeromeatneotek opened this issue Feb 28, 2024 · 7 comments

Comments

@jeromeatneotek
Copy link

error saving
Please let me know if you need any further info
@givanz
Copy link
Owner

givanz commented Feb 29, 2024

Can you please check if php has write permission for public/themes/landing/backup folder?

From the error message it looks that it can't save the page revision/backup.

@jeromeatneotek
Copy link
Author

I have ensured that this folder has full rights to everyone, but still the same error

@givanz
Copy link
Owner

givanz commented Feb 29, 2024

Maybe windows does not like some characters like :| from the filename?

Can you please try to create the file manually and see if windows allows it?

@jeromeatneotek
Copy link
Author

jeromeatneotek commented Feb 29, 2024 •
edited

Yes windows files cannot contain /|<>:*?", I would also suggest not using & either as these are problematic in XML.

@givanz
Copy link
Owner

givanz commented Feb 29, 2024

Thanks for confirmation, I will add a fallback for windows to use different separator characters.

@jeromeatneotek
Copy link
Author

Please confirm when done and I will test

givanz added a commit that referenced this issue Mar 1, 2024
@givanz
Reusable trait to save and regenerate reusable list when a new reusab…
56ef0bf 
…le section/block is added

Revisions trait for template revisions
Global trait to save global sections in templates like common footer/header.
Changed template revisions/backup file format to fix save issue on windows that doesn't allow | and : in file names #93
@givanz
Copy link
Owner

givanz commented Mar 1, 2024

I changed revision/backup file format, saving should work now on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@givanz @jeromeatneotek