Generosity challenge introduction by mayor (kids-872) #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniela510
commented
Apr 30, 2024
Comment on lines
+76
to
+80
| ), | ||
| SvgPicture.asset( | ||
| 'assets/images/mayor.svg', | ||
| height: pictureHeight, | ||
| ), |
There was a problem hiding this comment.
Should the mayor image also be hosted online? I think its a finished asset. What do other people think?
| ), | ||
| const SizedBox(height: 20), | ||
| const Text( | ||
| '— Mayor of Tulsa', |
There was a problem hiding this comment.
In design this is:
"— The Mayor of Tulsa"
| height: 0.3, | ||
| ), | ||
| ), | ||
| TextSpan( |
There was a problem hiding this comment.
Design has 8px spacing between Hi Superheroes and next line
pavelpavelko
approved these changes
Apr 30, 2024
|
|
||
| // update country iso in shared preferences | ||
| final prefs = get_it.getIt<SharedPreferences>(); | ||
| unawaited(prefs.setString('countryIso', selectedCountry.countryCode)); |
There was a problem hiding this comment.
perhaps add constant for 'countryIso'?
| const Text( | ||
| '— The Mayor of Tulsa', | ||
| style: TextStyle( | ||
| color: Color(0xFF003920), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description