Generosity challenge chat is integrated with the challenge itself #717

pavelpavelko · 2024-05-07T08:00:10Z

Description

day chat status moved to higher level and integrated with the generosity challenge
navigation is implemented for the challenge pages
chat icon with red dot indication is implemented (kids-871)
half-hidden "close" button is added to the chat page - it clears challenge progress and chat (for testing)

…igation between challege pages is implemented; chat icon with red dot is implemented

TammiLion · 2024-05-07T08:05:01Z

lib/app/routes/app_router.dart

+              final challengeCubit = state.extra! as GenerosityChallengeCubit;
+              return BlocProvider.value(
+                value: challengeCubit,
+                child: const GenerosityChallengeIntorduction(),


interoduction => introduction

TammiLion · 2024-05-07T08:10:25Z

lib/features/children/generosity_challenge/cubit/generosity_challenge_cubit.dart

@@ -28,6 +48,7 @@ class GenerosityChallengeCubit extends Cubit<GenerosityChallengeState> {
      );

  void dayDetails(int dayIndex) => emit(
+        //maybe here i need logic


I'd prefer if you'd elaborate the comment or if you make a ticket in Linear and then add a TODO, like:

// TODO KIDS-999 title

that is not mine, but I'll delete it

TammiLion · 2024-05-07T08:13:16Z

lib/features/children/generosity_challenge/models/day.dart

@@ -1,29 +1,52 @@
 import 'package:equatable/equatable.dart';
+import 'package:givt_app/features/children/generosity_challenge/models/enums/day_chat_status.dart';
+import 'package:givt_app/features/children/generosity_challenge_chat/chat_scripts/models/chat_script_item.dart';

 class Day extends Equatable {
  const Day({
    required this.dateCompleted,


Is there a reason why we're not using nullable for dateCompleted? I see in several places in the code that an empty string is assigned.

afaik we don't have clear rules here,
however my personal prefs is to avoid nullable when possible)

TammiLion · 2024-05-07T08:19:41Z

lib/features/children/generosity_challenge_chat/chat_scripts/pages/chat_script_page.dart

+        final showBackButton = context
+                .read<GenerosityChallengeCubit>()
+                .state
+                .availableChatDayIndex !=


So I can understand this PR better, "availableChatDayIndex" refers to the "latest" available day (so not the current active index or anything else)?

availableChatDayIndex actually it refers to the first non completed chat. There could be cases when active day index is not the same as active day chat index (for ex user still needs to pass through post chat of day 1, but the day 2 already available)

Daniela510 · 2024-05-07T08:29:29Z

lib/app/routes/app_router.dart

+            builder: (context, state) {
+              final challengeCubit = state.extra! as GenerosityChallengeCubit;
+              return BlocProvider.value(
+                value: challengeCubit,
+                child: const GenerosityChallengeIntorduction(),


There is no need for a BlocProvider here

I think we do need it, since we use it inside the introduction page here:
context.goNamed( Pages.generosityChallengeChat.name, extra: context.read<GenerosityChallengeCubit>(), );

Ah that's tricky, because the redirection to this page happens within _redirectFromExternalLink and we are not providing GenerosityChallengeCubit through there state.extra is null and i get a red exception screen when i get to this page currently. Funny enough when i removed the GenerosityChallengeCubit provider everything still worked as expected in the chat

changed based on talk with Daniela

Daniela510 · 2024-05-07T08:30:39Z

lib/app/routes/app_router.dart

+    if (navigatingPage == Pages.generosityChallenge.path &&
+        !GenerosityChallengeHelper.isActivated) {
+      return Pages.generosityChallengeIntroduction.path;
    }


because this is now a subroute it needs to be '${Pages.generosityChallenge.path}/${Pages.generosityChallengeIntroduction.path}'

according to the tests, subroutes are working with just a subroute part

i am not getting correctly redirected using the current code:

if i update using the whole path then i do get to the correct page

ohh, let me fix it then

I think using only the subroute works when redirecting by name, but this is using the path so it needs to be full 🤔

changed based on talk with Daniela: show intro from challenge itself, instead of redirection

Daniela510 · 2024-05-07T08:40:57Z

lib/features/children/generosity_challenge_chat/chat_scripts/widgets/chat_icon_button.dart

+                  extra: context.read<GenerosityChallengeCubit>(),
+                );
+              },
+              icon: const Icon(FontAwesomeIcons.solidComments),


tiny thing but the icon color should be AppTheme.givtGreen40, to match the color of the text in the appbar

Daniela510 · 2024-05-07T10:14:25Z

lib/app/routes/app_router.dart

@@ -855,10 +867,6 @@ class AppRouter {
      return Pages.generosityChallenge.path;


if (GenerosityChallengeHelper.isActivated || navigatingPage == Pages.generosityChallenge.path) - it's important for when users launch the app from link

pavelpavelko added 5 commits May 3, 2024 13:48

saveKey added to both model and script

dd7f846

merge with dev

16f8399

day chat statuses moved and integrated with generosity challenge; nav…

10e3d25

…igation between challege pages is implemented; chat icon with red dot is implemented

Merge branch 'develop' into feature/kids-877-save-user-data

7a7919d

post merge changes

570dae2

pavelpavelko requested a review from a team as a code owner May 7, 2024 08:00

github-actions bot added the enhancement New feature or request label May 7, 2024

TammiLion reviewed May 7, 2024

View reviewed changes

typo fix

a9009eb

TammiLion reviewed May 7, 2024

View reviewed changes

Daniela510 reviewed May 7, 2024

View reviewed changes

pavelpavelko added 3 commits May 7, 2024 11:54

code review improvements

dc174d3

routing is fixed

1dcc971

intial secret link routing is adjusted

5b7d9ae

Daniela510 reviewed May 7, 2024

View reviewed changes

Daniela510 approved these changes May 7, 2024

View reviewed changes

code review fix

2f162fe

pavelpavelko merged commit c340d94 into develop May 7, 2024
1 check passed

pavelpavelko deleted the feature/kids-877-save-user-data branch May 7, 2024 10:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generosity challenge chat is integrated with the challenge itself #717

Generosity challenge chat is integrated with the challenge itself #717

pavelpavelko commented May 7, 2024

TammiLion May 7, 2024

pavelpavelko May 7, 2024

TammiLion May 7, 2024

pavelpavelko May 7, 2024

pavelpavelko May 7, 2024

TammiLion May 7, 2024

pavelpavelko May 7, 2024

TammiLion May 7, 2024

pavelpavelko May 7, 2024

Daniela510 May 7, 2024

pavelpavelko May 7, 2024

Daniela510 May 7, 2024

pavelpavelko May 7, 2024

Daniela510 May 7, 2024

pavelpavelko May 7, 2024

Daniela510 May 7, 2024

pavelpavelko May 7, 2024

pavelpavelko May 7, 2024

Daniela510 May 7, 2024

pavelpavelko May 7, 2024

Daniela510 May 7, 2024

pavelpavelko May 7, 2024

Daniela510 May 7, 2024

pavelpavelko May 7, 2024

		@@ -855,10 +867,6 @@ class AppRouter {
		return Pages.generosityChallenge.path;

Generosity challenge chat is integrated with the challenge itself #717

Generosity challenge chat is integrated with the challenge itself #717

Conversation

pavelpavelko commented May 7, 2024

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment