Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generosity repo crashing on loading from cache. #744

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix generosity repo crashing on loading from cache. #744

merged 2 commits into from
May 14, 2024

Conversation

TammiLion
Copy link
Contributor

@TammiLion TammiLion requested a review from a team as a code owner May 14, 2024 07:29
@github-actions github-actions bot added the bug Something isn't working label May 14, 2024
pavelpavelko
pavelpavelko approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@pavelpavelko pavelpavelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)
looks like the reason of the crash was recent extension of the Day model, so that should be fixed

lib/features/children/generosity_challenge/repositories/generosity_challenge_repository.dart Outdated Show resolved Hide resolved
@TammiLion TammiLion merged commit 6452590 into develop May 14, 2024
1 check passed
@TammiLion TammiLion deleted the bug/generosity-challenge-load-from-cache-crash branch May 14, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelpavelko pavelpavelko pavelpavelko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TammiLion @pavelpavelko