Feature/kids 838 implement edit allowance screen #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[## Description
](https://linear.app/givt/issue/KIDS-838/implement-edit-allowance-screen)
https://linear.app/givt/issue/KIDS-840/remove-allowance-input-field-from-edit-profile-screen
So architecturally I kept this PR almost exactly the same as the current Givt app. I am building on the previous PR with the UIModel and having a "dumb" success screen. And in this PR I also illustrate a "dumb" edit allowance page. It's not wired to the cubit, it truly doesn't know anything, it just returns the result of the number that was set by the user when they click confirm (a result is not returned when back is pressed). I also added some convenient extensions so please check them out for future use.