Feature: top up screen (kids-843) #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TammiLion
reviewed
May 23, 2024
| @@ -77,13 +78,67 @@ class ChildDetailsCubit extends Cubit<ChildDetailsState> { | |||
| } | |||
| } | |||
|
|
|||
| Future<void> topUp(int amount) async { | |||
| await _logTopUpEvent(amount); | |||
There was a problem hiding this comment.
Small thing. Personally i would not "await" analytics event. So I would always wrap them in unawaited(); My reasoning is we wouldn't want to wait on analytics in the user experience and if analytics fail its not blocking for the app.
TammiLion
reviewed
May 23, 2024
| @@ -15,6 +15,10 @@ final class ChildDetailsFetchingState extends ChildDetailsState { | |||
| const ChildDetailsFetchingState(); | |||
| } | |||
|
|
|||
| final class ChildTupUpFundsErrorState extends ChildDetailsState { | |||
TammiLion
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description