Bugfix: Don't schedule notifications on Android 7 so the app doesnt crash #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TammiLion
reviewed
Jun 6, 2024
| @@ -286,6 +288,15 @@ class NotificationService implements INotificationService { | |||
| id ??= Random().nextInt(9999 - 1000) + 1000; | |||
|
|
|||
| await setupFlutterNotifications(); | |||
|
|
|||
| if (Platform.isAndroid) { | |||
| final androidInfo = await DeviceInfoPlugin().androidInfo; | |||
There was a problem hiding this comment.
Do you think it would be good to surround this section with a try/catch in case getting the info fails?
There was a problem hiding this comment.
Can you recheck? :)
There was a problem hiding this comment.
I think in this way we can catch errors while fetching android info and errors while scheduling the notification.
In all error cases i'm not scheduling the notification, just to be sure.. :)
TammiLion
approved these changes
Jun 6, 2024
MaikelStuivenberg
deleted the
bug/kids-798-givt-app-doesnt-work-anymore-on-android-7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description