Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: parents history feed sometimes shows a grey area (KIDS-1075) #811

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

TammiLion
Copy link
Contributor

@TammiLion TammiLion commented Jun 17, 2024

Description

https://linear.app/givt/issue/KIDS-1075/parents-history-feed-is-broken


🚀 This description was created by Ellipsis for commit e6cf898

Summary:

Fixed parents' history feed grey area issue by changing stream controllers to broadcast mode in auth_repository.dart and edit_child_repository.dart.

Key points:

  • Modified lib/features/auth/repositories/auth_repository.dart.
    • Changed _hasSessionStreamController to StreamController<bool>.broadcast().
  • Modified lib/features/children/edit_child/repositories/edit_child_repository.dart.
    • Changed _childGUIDController to StreamController<String>.broadcast().

Generated with ❤️ by ellipsis.dev

@TammiLion TammiLion requested a review from a team as a code owner June 17, 2024 11:41
@github-actions github-actions bot added the bug Something isn't working label Jun 17, 2024
@TammiLion TammiLion changed the title Bugfix: parents history feed sometimes shows a grey area (KIDS-1073) Bugfix: parents history feed sometimes shows a grey area (KIDS-1075) Jun 17, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e6cf898 in 32 seconds

More details
  • Looked at 29 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. lib/features/auth/repositories/auth_repository.dart:99
  • Draft comment:
    Changing the _hasSessionStreamController to a broadcast stream allows multiple listeners. Ensure that this change aligns with the intended use cases in the application and that there are indeed multiple components that need to listen to this stream.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The change from a regular StreamController to a broadcast StreamController in both files allows multiple listeners to subscribe to the same stream. This is a significant change because it affects how the stream can be used throughout the application. If the intent is to allow multiple parts of the application to listen to the stream without causing an exception (which happens if multiple listeners are added to a non-broadcast stream), this change is correct. However, it's important to ensure that this change aligns with the application's architecture and that there are indeed multiple listeners for these streams.

Workflow ID: wflow_lXiTsGM9ezD29lHq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

1 day left in your free trial, upgrade for $20/seat/month or contact us.

@TammiLion TammiLion merged commit aa92175 into develop Jun 17, 2024
1 check passed
@TammiLion TammiLion deleted the bug/kids-1075-history-feed-is-broken-sometimes branch June 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants