New feature : List - color per line

[yesnault]

Hi,

It would be nice to be able to define a line (per line) color in the widget list.

Thks !

[gizak]

Hi @yesnault , this will be a useful feature! I think we can put it this way:

data = []string{
  "1. pass: foobar0",
  "[[color=red]]2. warning: foobar1",
  "3. pass: foobar2"}

If one wants to specify a particular color, insert a piece like [[color=xxx]] in the front into the data passing to List, then List can detect it and render it differently. This will avoid adding in dramatic changes in current codes.

[yesnault]

LGTM !
Le sam. 14 mars 2015 à 20:24, Zack Guo notifications@github.com a écrit :

Hi @yesnault https://github.com/yesnault , this will be a useful
feature! I think we can put it this way:

data = []string{
"1. pass: foobar0",
"[[color=red]]2. warning: foobar1",
"3. pass: foobar2"}

If one wants to specify a particular color, insert a piece like
[[color=xxx]] in the front into the data passing to List, then List can
detect it and render it differently. This will avoid adding in dramatic
changes in current codes.

—
Reply to this email directly or view it on GitHub
#4 (comment).

[yesnault]

I don't know if it's possible or better, but another solution is to use same syntax than term color, like that for yellow color

\e[33;My Text here

[gizak]

@yesnault I like your solution, since it looks more "natural" in the sense of terminal printing:)

[warmans]

Another option I've seen is to use HTML style syntax e.g.

item := "<style color="red">ERROR</style> Something went wrong" 

This is nice as it lets you color individual parts of a line.

[gizak]

That seems pretty good, but have to type up many chars. How about this:

item := "[ERROR](red,bold) Something went wrong"

Does the same thing but uses markdown-like syntax.

[yesnault]

+1

[Matt3o12]

Has anyone already started working on it? If not, I could start in a few days.

[gizak]

👍 That would be great! I was also thinking maybe we can apply this for any text rendering not just List. Introduced a new struct text that:

text.Len() int // return string real length
text.Buffer() []Point// return Points
text.SetBg(Attribute)
text.SetFg(Attribute)

Then all text procedures can use this structure to render, which gives the ability of using specific color.

[fgrehm]

👍

[Matt3o12]

While something like that was my initial idea, it is not going to work because of text overflows.
I will implement an Api that is easy to implement and customizable. I was thinking of an interface that implements a method for the normalized text (I.e. All formating elements are stripped out) so the list class can work with that text. But instead of creating the buffer itself, there will be a method that will return a buffer for the given text sequence.

This should not break backwards compatibility and it will be customizable so that @warmans can implement his html formating if he wants to.
I will implement markdown and ASCII escape codes.

Sent from my iPhone

On Apr 1, 2015, at 1:25 AM, Zack Guo notifications@github.com wrote:

That would be great! I was also thinking maybe we can apply this for any text rendering not just List. Introduced a new struct text that:

text.Len() int // return string real length
text.Buffer() []Point// return Points
text.SetBg(Attribute)
text.SetFg(Attribute)
Then all text procedures can use this structure to render, which gives the ability of using specific color.

—
Reply to this email directly or view it on GitHub.

[divan]

+1 for markdown syntax: it's easy to pick up even if you're terminal codes guy.

[Matt3o12]

@divan:
Both are already implemented and the pull request #22 is pending

[omeid]

👍

[gizak]

Done!

[yesnault]

Thanks to everyone !