Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for umbrella project. #22

Merged
merged 1 commit into from Mar 10, 2016
Merged

Conversation

seantanly
Copy link
Contributor

Add support for phoenix under umbrella project.

Fixes issue #21

@bhserna
Copy link

bhserna commented Mar 7, 2016

Hi @seantanly, I am needing also a solution for the issue #21, but I can't make your fix to work for me =( ...

I am just adding a file phoenix_static_buildpack.config with...

phoenix_relative_path="apps/my_phoenix_web_app"

And watching the logs all goes well but when I visit the app in the web browser the assets are not there.

@seantanly
Copy link
Contributor Author

Hi @bhserna, are you able to share on Github a stripped down version of your app so that I can take a look?

@bhserna
Copy link

bhserna commented Mar 8, 2016

@seantanly I upload a test app here https://github.com/bhserna/heroku-build-pack-test-case ... I removed all the application code, but is basically the same configuration.

Thanks for your help!

@seantanly
Copy link
Contributor Author

@bhserna You might be simply missing the following in your apps/food_shop_web/mix.exs.

   def project do
     [app: :food_shop_web,
      version: "0.0.1",
+     build_path: "../../_build",
+     config_path: "../../config/config.exs",
      deps_path: "../../deps",
      lockfile: "../../mix.lock",

I have this version working on my Dokku deployment. https://github.com/seantanly/heroku-build-pack-test-case

Note that I'm pointing to my version of phoenix buildpack which contains the fix since this fix isn't merged into official master yet.

@bhserna
Copy link

bhserna commented Mar 10, 2016

@seantanly thanks!! your fix and those two lines make it work for me!!

@seantanly
Copy link
Contributor Author

@bhserna you're welcome! Let's hope the fix gets merged into master soon. :) @gjaldon ;)

gjaldon added a commit that referenced this pull request Mar 10, 2016
Add support for umbrella project.
@gjaldon gjaldon merged commit e1b8cd5 into gjaldon:master Mar 10, 2016
@gjaldon
Copy link
Owner

gjaldon commented Mar 10, 2016

Thanks guys for testing this out! @seantanly @bhserna and thanks @seantanly for the PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants