Var in release #88
Merged
Var in release #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor change since it looks like $BUILD_DIR/PHOENIX_EX_VAR is supposed to exist so we can remove the conditional to check if it exists
|
This is awesome @rccursach! Thanks a lot :) Let me know if you've tested with a deploy and if it's good to merge. Hope you don't mind the minor change I in Should add automated tests and CI for this buildpack so we no longer need to manually test in the future |
|
Yeah, makes sense removing that IF, the var is already there always. Good to merge :). Tested with 1.3.x on heroku and dokku and works fine . (Also looked in other Buildpacks for how testing is done. it's a lot of work, but the buildpacks from heroku have pretty consistent code base, independently of what framework/lang are targeted for. 👓) |
|
Awesome! Thanks a lot for this contribution 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passed
phoenix_exvar fromlib/common.sh#load_config()tobin/releasethrough a small file generated in $BUILD_DIR.Calling load_config() from inside
releasecaused error, because of the messages echoed from load_config() were considered part of the YAML output generated by the release script.also changed the logic of load_config(), bc phoenix 1.3.x apps have a package.json on ./assets/, that wasn't detected. and moved the sourcing of
phoenix_static_buildpack.configat the end to override what was already set from the defaults if the file is present.