Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Drag modules icons when in course Edit mode, are partly misplaced. #728

Closed
nadavkav opened this issue Aug 28, 2016 · 33 comments
Closed

Drag modules icons when in course Edit mode, are partly misplaced. #728

nadavkav opened this issue Aug 28, 2016 · 33 comments
Assignees
@gjb2048
Labels
Cannot reproduce Not a bug

Comments

@nadavkav
Copy link
Contributor

image
@gjb2048 gjb2048 self-assigned this Aug 28, 2016
@gjb2048
Copy link
Owner

gjb2048 commented Aug 28, 2016

Related to: https://moodle.org/mod/forum/discuss.php?d=337924

@nadavkav
Copy link
Contributor Author

Exactly

@gjb2048
Copy link
Owner

gjb2048 commented Aug 28, 2016

But cannot reproduce. What are the settings for layout etc?

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

Course format?

More info please Nadav.

@nadavkav
Copy link
Contributor Author

Oups, sorry.
Regular "topics"

@nadavkav
Copy link
Contributor Author

http://themes.moodlemagic.info/course/view.php?id=2

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

Thanks for the link, however, guest access and cannot turn editing on!

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

Still cannot replicate locally.

@nadavkav
Copy link
Contributor Author

You got email with admin privileges, enjoy 😄

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016 •
edited

Thanks.

I've found some CSS on your site that does not exist in the theme:

.section .activity .editing_move {
    position: absolute;
    left: 0;
    top: 0;
}

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

Turned on TDM but could not find it. TDM now off. Not in Custom CSS.

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

But in Bootstrapbase course.less there is:

        .editing_move {
            /* Move the move icon to the start of the line */
            position: absolute;
            left: 0;
            top: 0;
        }

Humm!

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

Ok... that's in local... humm.

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

So why is your left indent less than mine?

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016 •
edited

Ok.... Bug in the Board course format styles.css line 65 which has:

.section .activity .mod-indent-outer {
    padding: 0 !important;
}

Therefore not a problem with the theme, but with the Board format which should have CSS specific to it like I do in Grid and Collapsed Topics etc.

Moodle loads all CF CSS regardless of format used.

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

Grrrr.

@gjb2048 gjb2048 closed this as completed Aug 30, 2016
@nadavkav
Copy link
Contributor Author

nadavkav commented Aug 30, 2016 •
edited

Found it. It's in Moodle's bootstrapbase
https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/course.less#L69

@nadavkav
Copy link
Contributor Author

Ok. now I see you also found it (a few comment before me)

@nadavkav
Copy link
Contributor Author

I do not have Board course format installed.

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

TDM on.... Yes you do! Explain this then! ->

2016-08-30 18_14_33-start

@nadavkav
Copy link
Contributor Author

Mmmm...
It is probably something else, checking...

@nadavkav
Copy link
Contributor Author

I think I found it. it is actually...

.path-course-view li.activity>div, .path-site li.activity>div {
    position: relative;
    padding: 0 16px 0 0;
}

Where it should be:

.path-course-view li.activity>div, .path-site li.activity>div {
    position: relative;
    padding: 0 0 0 16px;
}

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

No Nadav, Sorry you are wrong.

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016 •
edited

Ok, save time, agree with me! Right, in Chrome if I disable that 'iffy' CSS in the Board format then everything becomes as it should:

2016-08-30 18_27_41-new notification

Therefore a problem with the Board course format!!!!!!!!!

@nadavkav
Copy link
Contributor Author

I would LOVE to agree but I do not have Board course format installed. (still looking for that code on the entire Moodle install)
And also added the following code:

.editing.path-course-view li.activity>div, 
.editing.path-site li.activity>div {
    position: relative;
    padding: 0 0 0 16px;
}

Which looks much better now. (but might not be the right/correct solution)

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

Ok,

So why does this URL - http://themes.moodlemagic.info/course/format/board/styles.css - give a style sheet then?

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

You have the board course format installed:

2016-08-30 18_36_57-start

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

I'm not sure I can put it any other way!!!!!!!!

@nadavkav
Copy link
Contributor Author

Me BAD! My phpStorm IDE was not synced with the installed plugins on the server.

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

At last!!!!

@nadavkav
Copy link
Contributor Author

:-( so sorry

@nadavkav
Copy link
Contributor Author

Ok. just send you a 50USD "donation" through http://www.moodlegarage.com/ or else I cound not live with myself

@gjb2048
Copy link
Owner

gjb2048 commented Aug 30, 2016

Thank you Nadav.

nadavkav added a commit to nadavkav/moodle-format_board that referenced this issue Sep 2, 2016
@nadavkav
Fix Board styles that affect other course format
9573554 
CSS selectors from this course format are not specific enough to this course format, and so, cause issues on other course formats.
This fix was found by @gjb2048 while discussing an alleged issue on the wrong theme (Essential), see: 
gjb2048/moodle-theme_essential#728 (comment)
@nadavkav nadavkav mentioned this issue Sep 2, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gjb2048 gjb2048

Labels
Cannot reproduce Not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nadavkav @gjb2048