Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokssh: shared secret support,fix no user cmd line #38

Merged
merged 2 commits into from
Apr 8, 2017
Merged

tokssh: shared secret support,fix no user cmd line #38

merged 2 commits into from
Apr 8, 2017

Conversation

fabrixxm
Copy link
Contributor

@fabrixxm fabrixxm commented Apr 7, 2017

No description provided.

@gjedeer
Copy link
Owner

gjedeer commented Apr 8, 2017

Thanks!

@gjedeer gjedeer closed this Apr 8, 2017
@gjedeer gjedeer reopened this Apr 8, 2017
@gjedeer gjedeer merged commit c2ce177 into gjedeer:master Apr 8, 2017
@gjedeer
Copy link
Owner

gjedeer commented Apr 8, 2017

Merged but in general, TUNTOX_SHARED_SECRET env variable is preferred to the -s switch.

@fabrixxm
Copy link
Contributor Author

in general, TUNTOX_SHARED_SECRET env variable is preferred to the -s switch.

Yup..
And as a "client" command line tool, better would be "-s" alone and ask user the password interactively, like ssh itself or mysql client with "-p" :-)

@fabrixxm fabrixxm deleted the patch-1 branch April 10, 2017 08:07
@gjedeer gjedeer mentioned this pull request Apr 10, 2017
Open
@gjedeer
Copy link
Owner

gjedeer commented Apr 10, 2017

Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjedeer gjedeer gjedeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabrixxm @gjedeer