Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavenize #4

Closed
wants to merge 3 commits into from
Closed

Mavenize #4

wants to merge 3 commits into from

Conversation

rpardini
Copy link

It should address #1
I added a fake "IntegrationTest" (copied from Demo.asciidoc) that doesn't actually test anything without human input and so can be ignored.

@gjoseph
Copy link
Owner

gjoseph commented Mar 16, 2015

Thanks a lot ! I actually have the same locally, not pushed, because I wanted to figure out the license issues first.

@gjoseph gjoseph closed this Mar 16, 2015
@gjoseph
Copy link
Owner

gjoseph commented Mar 16, 2015

Fixed with d6755c0, thanks again. Let me know if you think anything's missing. I'll try to cut a release soon, but still need to go through licensing (#2) once more, since some code was copied off of OpenJDK, it seems it might be a little delicate.

@rpardini
Copy link
Author

Yeah, thanks. I wanted to investigate performance and mavenization was a prereq.
I did not find performance to be that much better than JDK7+, and probably not worth the trouble.
Maybe JDK7+ uses similar code already, and it's Apple's fault for the slowness, I wonder?
In any case I agree this should probably be Apache v2...

@gjoseph
Copy link
Owner

gjoseph commented Mar 17, 2015

Hmm, tbh I haven't tested the project since Mavenizing, but it should work better than JDK7. On OSX, JDK7 has no native filesystem watch mechanism, so it relies on polling, and polls the watch keys, IIRC every 10 seconds. Almost instantaneous with BarbaryWatchService. I'll def make sure to add proper testing before releasing. Yesterday I was focusing on getting Travis to deploy snapshots to sonatype; almost there, as soon as I managed to convince Travis to build it on osx.

@gjoseph gjoseph mentioned this pull request Mar 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants