Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore axis if dim is given #149

Merged
merged 1 commit into from
May 16, 2022
Merged

Ignore axis if dim is given #149

merged 1 commit into from
May 16, 2022

Conversation

aazuspan
Copy link
Contributor

Override axis if a dim is provided to make sure both can't be passed to DataArray.reduce (fixes #148). Test coverage added to make sure mosaic is tested with and without a dim passed.

gjoseph92
gjoseph92 approved these changes May 9, 2022
View reviewed changes
Copy link
Owner

@gjoseph92 gjoseph92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aazuspan, this looks good!

I'm quite sure the failing docs builds #151 aren't related to your changes, but I may try to fix that before merging. If I don't get to it in a couple days, just ping me and I'll merge it.

@gjoseph92
Copy link
Owner

Never got around to looking into the docs builds, so I'll merge this now.

@gjoseph92 gjoseph92 merged commit 0dff7cf into gjoseph92:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoseph92 gjoseph92 gjoseph92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError when passing any dim to mosaic
2 participants
@aazuspan @gjoseph92