Ignore assets that don't have a type, if filtering by mimetype
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, just ignore assets that are missing a `type`.
TomAugspurger
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
@TomAugspurger we could certainly add inference in the future, but for now I didn't want to add the complexity. Stackstac requires plenty of other metadata that goes beyond the basic STAC required fields (geolocation / the
projextension, etc.), so I feel okay about requiring this too in the case where you're specifying assets by mimetype.I'm expecting this is a rare case, so encouraging users to explicitly specify asset IDs in this case feels okay instead of automatically doing something we can't be sure is correct. We can reconsider depending on how often it comes up.
cc @scottyhq