Fix accumulate_metadata
replacing coordinates with Nones
#88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
While reviewing #87, I realized there were many things wrong with
accumulate_metadata
. The function just had too many cases and was trying to do too many things. #40 allowed for some incorrect code paths which we aren't actually using, but would be annoying to handle correctly. So instead, I basically redid #40, splittingaccumulate_metadata
into one function for the normal properties case, and one for the asset-metadata case where we only care about fields that have the same value everywhere.@scottyhq I believe this fixes your example, but would be good to confirm:
![Screen Shot 2021-11-14 at 1 17 15 AM](https://user-images.githubusercontent.com/3309802/141673811-4f3ee835-661b-482f-88a5-25d20d2a241a.png)