Beta fixes: Optional Properties handling #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the new Beta of
ts-for-gir
the approach to optional parameters has changed, now everywherePartial<XY.ConstructorProps>
is used, instead of declaring each property in theConstructorProps
property?: xy
This breaks many things, and they all have to be changed, this wasn't caught before, since apparently no-one (including me) used the
4.0.0-beta.2
types.I'll try to find all places and then squash it into one commit.
Here's a fun screenshot, of using this types with the
beta-2
packages: