Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta fixes: Optional Properties handling #34

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Beta fixes: Optional Properties handling #34

merged 3 commits into from
Apr 19, 2024

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented Apr 18, 2024

Since the new Beta of ts-for-gir the approach to optional parameters has changed, now everywhere Partial<XY.ConstructorProps> is used, instead of declaring each property in the ConstructorProps property?: xy

This breaks many things, and they all have to be changed, this wasn't caught before, since apparently no-one (including me) used the 4.0.0-beta.2 types.

I'll try to find all places and then squash it into one commit.

Here's a fun screenshot, of using this types with the beta-2 packages:

image

@swsnr
Copy link
Collaborator

swsnr commented Apr 19, 2024

@Totto16 You need to resolve merge conflicts here 🙂

@Totto16
Copy link
Collaborator Author

Totto16 commented Apr 19, 2024

Merging this, since nothing changed, other than the merge conflict resolution

@Totto16 Totto16 merged commit 1422445 into main Apr 19, 2024
2 checks passed
@Totto16 Totto16 deleted the beta-fixes branch April 19, 2024 12:10
@Totto16
Copy link
Collaborator Author

Totto16 commented Apr 19, 2024

Note: I released this and the previous commits to npm as 46.0.0-4.0.0-beta.3 in the next tag on npm and as a prerelease here on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants