Migrate to comrak/Rust #185
Conversation
Was only used to assist in bringing upstream cmark sources in.
|
Looking awesome so far. Is it ridiculously presumptuous of me to add commits to this branch? Drop them if you have any reservations at all, just acting on my compulsions a little bit; removed the out of date Makefile in a76379a, and added some casts for |
Not at all! I usually have only a few hours a week free to work on this so any help is appreciated. |
| end | ||
|
|
||
| # Why is this so long? | ||
| tarball_extract_path = File.join("tmp", recipe.host, "ports", recipe.name, recipe.version, "#{recipe.name}-#{recipe.version}") |
There was a problem hiding this comment.
@kivikakk I'm real embarrassed you had to see all this, hah
|
PR looks great. Truly, thanks so much for your help. In a subsequent (final?) PR, I'm going to use https://github.com/rake-compiler/rake-compiler-dock to precompile native gems. |
Will close #107
pure fyi to @kivikakk for demo of how to integrate Rust into Ruby. I need to study more on how to package the gem itself as a precompiled artifact for various OSes (which Nokogiri recently did).
For anyone else reading this: node iteration/manipulation will probably not be supported during the major release cut over off of C and onto Rust. I'd like to incorporate https://github.com/gjtorikian/selma into https://github.com/gjtorikian/html-pipeline and encourage using a post-processor. Part of this stems from the fact that implementing an AST parser in Ruby is slow; selma also uses a Rust create to more efficiently change multiple nodes at once (via CSS selectors).
So, basically, I'm working on all three of these projects at once, but they won't be released until I can manage to make precompiled gems happen.