Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmailReplyParser is undefined #107

Closed
foca opened this issue Feb 2, 2014 · 5 comments · Fixed by #110
Closed

EmailReplyParser is undefined #107

foca opened this issue Feb 2, 2014 · 5 comments · Fixed by #110

Comments

@foca
Copy link
Contributor

foca commented Feb 2, 2014

I might be missing some dependency, but the EmailReplyFilter references an EmailReplyParser constant which is not defined in the gem, at all :)

Can't remember if this is something that was there in github/github or maybe github/html-pipeline? But it should proooobably be here. Or maybe it's EmailReplyFilter that shouldn't be :P

@jch
Copy link
Contributor

jch commented Feb 3, 2014

@foca good catch. It looks like we forgot to specify an external dependency to https://github.com/github/email_reply_parser. Would you be interested in writing a pull request for this?

P.S. How've you been? I haven't talked to you in forever, hope everything's going well 😉

@foca
Copy link
Contributor Author

foca commented Feb 4, 2014

Ah, awesome. Didn't see that was open sourced! I'll send a PR soon :)

I've been great. How about you? I'm trying to figure out how to sneak a visit to the west coast and catch up with everyone :D miss you guys! ^_^

On Mon, Feb 3, 2014 at 7:53 PM, Jerry Cheung notifications@github.com
wrote:

@foca good catch. It looks like we forgot to specify an external dependency to https://github.com/github/email_reply_parser. Would you be interested in writing a pull request for this?

P.S. How've you been? I haven't talked to you in forever, hope everything's going well 😉

Reply to this email directly or view it on GitHub:
#107 (comment)

@simeonwillbanks
Copy link
Contributor

@foca For your convenience, I can send a Pull Request. We just refactored dependency management, and it's fresh in my head. Let me know! 😄

@foca
Copy link
Contributor Author

foca commented Feb 5, 2014

@simeonwillbanks thanks! But it's no problem, it was simple enough to do :)

@simeonwillbanks
Copy link
Contributor

@foca Very cool. Thanks for the help! 🤘

@jch jch closed this as completed in #110 Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants