Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters Manage Dependencies #80

Merged
merged 10 commits into from
Oct 23, 2013

Commits on Aug 25, 2013

  1. Filters Manage Dependencies

    * Add dependency management test cases for each `Filter` with a
      dependency
    * Add `assert_dependency_management_error` custom assertion which
      asserts a custom exception and message are raised if a dependency
      is missing
    * Move all `Filter` dependencies to `Gemfile` `:test` block for
      test cases and CI
    * Implement `TestingDependency` helper to abstract unloading and
      loading `Gemfile` `:test` block gems when asserting dependency
      management errors
    * Implement `MissingDependencyException` custom exception with
     `MESSAGE` constant as a format string, so each `Filter` raises a
      uniform exception
    * Add `begin..rescue..end` blocks around each `Filter` `require`
      statement to raise a `MissingDependencyException` when a gem can
      not be loaded
    * Update README.md detailing new dependency management with listing
      of `Filter` gem dependencies
    * Add gemspec post install message to inform users their apps must
      bundle `Filter` dependencies
    Simeon F. Willbanks committed Aug 25, 2013
    1 Configuration menu
    Copy the full SHA
    d3fc6d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2013

  1. Address Pull Request comments:

    * Copy edit README.md
    * In gemspec, link README.md dependencies and update post install message
    * Rename test helper to `assert_dependency`
    * Remove `TestingDependency` in favor of stubbing `Kernal#require`
    Simeon F. Willbanks committed Aug 28, 2013
    Configuration menu
    Copy the full SHA
    c25c890 View commit details
    Browse the repository at this point in the history
  2. Textile Filter does require RedCloth

    Simeon F. Willbanks committed Aug 28, 2013
    Configuration menu
    Copy the full SHA
    f0983dc View commit details
    Browse the repository at this point in the history
  3. Move ActiveSupport::XmlMini_Nokogiri to test helper, since its mixed …

    …in #to_hash is only used by #assert_equal_html
    Simeon F. Willbanks committed Aug 28, 2013
    Configuration menu
    Copy the full SHA
    f9c6d06 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2013

  1. Merge upstream/master; activesupport is a full dependency

    Simeon F. Willbanks committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    e042c3e View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2013

  1. Relative link to Gemfile

    Simeon F. Willbanks committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    0471de4 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/master' into simple-dependency…

    …-management
    Simeon F. Willbanks committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    3801fd5 View commit details
    Browse the repository at this point in the history
  3. Don't test dependency management since its testing require and is bri…

    …ttle
    Simeon F. Willbanks committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    154ef94 View commit details
    Browse the repository at this point in the history
  4. No need for MissingDependencyException

    Simeon F. Willbanks committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    6ff25ad View commit details
    Browse the repository at this point in the history
  5. If a dependency is missing, exit with a 1 status and write help messa…

    …ge to STDERR.
    Simeon F. Willbanks committed Oct 23, 2013
    Configuration menu
    Copy the full SHA
    a0acb69 View commit details
    Browse the repository at this point in the history