Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag picture invalid #298

Closed
Tuckie opened this issue Jan 22, 2016 · 6 comments
Closed

Tag picture invalid #298

Tuckie opened this issue Jan 22, 2016 · 6 comments

Comments

@Tuckie
Copy link

Tuckie commented Jan 22, 2016

Any idea why this throws a Tag picture invalid error? I'm running 2.6.1. It checks out fine with W3C's validator.

<a class="first-banner" href="news/promo/">
<picture>
<!--[if IE 9]><video style="display: none;"><![endif]-->
<source srcset="assets/images/banner-large.png" media="(min-width: 1200px)" />
<!--[if IE 9]></video><![endif]-->
<img src="assets/images/banner-small.png" srcset="assets/images/banner-small.png" alt="the more you save" />
</picture>
</a>
@gjtorikian
Copy link
Owner

Hmm. Could you post the full error (including line number)?

@Tuckie
Copy link
Author

Tuckie commented Jan 25, 2016

I've created a reduced test case:

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <title>title</title>
  </head>
  <body>
<picture>
<!--[if IE 9]><video style="display: none;"><![endif]-->
<source srcset="https://placehold.it/350x150" media="(min-width: 1200px)" />
<!--[if IE 9]></video><![endif]-->
<img src="https://placehold.it/350x150" srcset="https://placehold.it/350x150" alt="the more you save" />
</picture>
  </body>
</html>
Running ["ScriptCheck", "HtmlCheck", "ImageCheck", "LinkCheck"] on ./build on *.


Ran on 177 files!


- ./build/index.html
  *  Tag picture invalid (line 8)
rake aborted!

FYI, I'm currently running it with:

task :proof do
  options = {
    check_external_hash: true,
    check_html: true,
    disable_external: true,
    typhoeus: { proxy: ENV['http_proxy'] }
  }
  HTML::Proofer.new('./build', options).run
end

@gjtorikian
Copy link
Owner

This'll be fixed in HTML-Proofer 3.0.

@Tuckie
Copy link
Author

Tuckie commented Mar 3, 2016

Awesome, thank you!

@gjtorikian
Copy link
Owner

Closed by HTMLProofer 3.0: https://github.com/gjtorikian/html-proofer/releases/tag/v3.0.0

@Tuckie
Copy link
Author

Tuckie commented Mar 15, 2016

It's working great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants