Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved PDF hash handling #789

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Improved PDF hash handling #789

merged 4 commits into from
Jan 20, 2023

Conversation

gjtorikian
Copy link
Owner

Closes #787

@gjtorikian gjtorikian merged commit 2e03f16 into main Jan 20, 2023
@gjtorikian gjtorikian deleted the external-hash-crash branch January 20, 2023 16:50
@stevecheckoway
Copy link
Contributor

Would you mind changing the tests so that they're not fetching PDFs from my website? I provided that just as an example of a link that failed because the PDF was parsed as html. I'm definitely not committing to maintaining slides for old classes I've taught at the same URL forever.

@gjtorikian
Copy link
Owner Author

gjtorikian commented Jan 21, 2023

The test suite uses VCR to record the (expensive) HTTP call once, and then simply reuses that fixture any time the test is run again: https://github.com/gjtorikian/html-proofer/blob/f2dfd3a36c8881dd04290c6ac62dd25a881b189e/spec/html-proofer/fixtures/vcr_cassettes/links/pdf_w_hash_broken_html_log_level_error_type_file_.yml

Is that ok?

@stevecheckoway
Copy link
Contributor

That contains the complete PDF. I don't own the contents of that PDF (they are lecture slides I use with permission from the author). Please use a different PDF.

@gjtorikian
Copy link
Owner Author

Ok in the future please provide a test case that is safe to reproduce please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing when checking the external hashes of URLs
2 participants