Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta e2000 #269

Merged
merged 7 commits into from
Jan 27, 2022
Merged

Delta e2000 #269

merged 7 commits into from
Jan 27, 2022

Conversation

vasilzhigilei
Copy link
Contributor

Updated deltaE function to implement the "Delta E (CIE 2000)" formula found here: http://www.brucelindbloom.com/index.html?Eqn_DeltaE_CIE2000.html
Wrote test cases for function, passes all test cases.

Resolves #175 issue.

@vasilzhigilei
Copy link
Contributor Author

@gka

@gka
Copy link
Owner

gka commented Jan 27, 2022

hi @vasilzhigilei! apologies for taking so long. I think your proposal makes sense. Let's merge it!

Copy link
Owner

@gka gka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chroma.deltaE is not really Delta E
2 participants