Skip to content

Commit

Permalink
fix(jenkins): Fix the format for passing parameters to Grunt tasks
Browse files Browse the repository at this point in the history
The Jenkins build.sh script has to be updated as the previous way of
specifying parameters to the code run in Grunt tasks stopped working
with the newest Grunt. This has been previously fixed for the Travis
build.sh but wasn't done for the Jenkins one.

Also, the contribute docs were updated to account for the new format.
  • Loading branch information
mgol committed Aug 5, 2016
1 parent c322032 commit 5fc9933
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/content/misc/contribute.ngdoc
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ grunt test:unit
To run the tests on other browsers (Chrome, ChromeCanary, Firefox, Opera and Safari are pre-configured) use:

```shell
grunt test:unit --browsers Opera,Firefox
grunt test:unit --browsers=Opera,Firefox
```

Note there should be _no spaces between browsers_. `Opera, Firefox` is INVALID.
Expand Down
4 changes: 2 additions & 2 deletions scripts/jenkins/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ grunt ci-checks package --no-color
mkdir -p test_out

# UNIT TESTS #
grunt test:unit --browsers $BROWSERS --reporters=dots,junit --no-colors --no-color
grunt test:unit --browsers="$BROWSERS" --reporters=dots,junit --no-colors --no-color

# END TO END TESTS #
grunt test:ci-protractor

# DOCS APP TESTS #
grunt test:docs --browsers $BROWSERS --reporters=dots,junit --no-colors --no-color
grunt test:docs --browsers="$BROWSERS" --reporters=dots,junit --no-colors --no-color

# Promises/A+ TESTS #
grunt test:promises-aplus --no-color
Expand Down

0 comments on commit 5fc9933

Please sign in to comment.