fix: race condition when updating snapshots in parallel (#97)

gkampitakis · Apr 5, 2024 · e31ee30 · e31ee30
1 parent 9822328
commit e31ee30
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/snaps/snapshot.go b/snaps/snapshot.go
@@ -15,7 +15,7 @@ import (
 
 var (
 	testsRegistry        = newRegistry()
-	_m                   = sync.Mutex{}
+	_m                   = sync.RWMutex{}
 	endSequenceByteSlice = []byte(endSequence)
 )
 
@@ -129,6 +129,9 @@ func newRegistry() *syncRegistry {
 //
 // If not found returns errSnapNotFound error.
 func getPrevSnapshot(testID, snapPath string) (string, int, error) {
+	_m.RLock()
+	defer _m.RUnlock()
+
 	f, err := os.ReadFile(snapPath)
 	if err != nil {
 		return "", -1, errSnapNotFound