fix: update isSkippedFile, replace file absolute match w/ regex match #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasyris
force-pushed
the
isFileSkipped
branch
from
ea5609c
to
24fa9c6
Compare
remove types from test reset changes
parasyris
force-pushed
the
isFileSkipped
branch
from
24fa9c6
to
3433b3e
Compare
|
Thanks a lot for the contribution. Yup missed that. Seems you need to run |
gkampitakis
reviewed
Oct 1, 2022
parasyris
force-pushed
the
isFileSkipped
branch
from
ba07329
to
3afe766
Compare
gkampitakis
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 馃憢 , I noticed an edge case issue on isFileSkipped. The
runflag is accepting a regex but theisFileSkipped is doing an absolute match. I have seen there is a relevant fix but probably missed this point
9c6ad4b.
So I changed to regex match and added a unit test.
Did also a minor change in testSkipped, shouldn't affect anything just moved the regex checking if a test
is skipped at the end just to defer the regex matching.