Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate carbon metadata and function prototypes in headers #33

Merged
merged 3 commits into from
Dec 25, 2020

Conversation

shtrom
Copy link
Contributor

@shtrom shtrom commented May 29, 2019

This is needed to successfully build dependent projects such as Lurch4Adium

Signed-off-by: Olivier Mehani olivier.mehani@learnosity.com

This is needed to successfully build dependent projects such as Lurch4Adium

Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
@gkdr
Copy link
Owner

gkdr commented Dec 28, 2019

Thanks again for the contribution, I'll include it soon. What does the "int" in the filename stand for though?

@shtrom
Copy link
Contributor Author

shtrom commented Dec 30, 2019

internal, I think I took the pattern from somewhere else, but can't recall where.

@gkdr gkdr changed the base branch from master to dev October 21, 2020 21:13
@gkdr
Copy link
Owner

gkdr commented Dec 8, 2020

sorry i didn't follow up on this - could you just name it internal instead then? 🙂

@gkdr
Copy link
Owner

gkdr commented Dec 19, 2020

thanks! it seems you forgot to update a reference in the test files.

@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #33 (7d73c20) into dev (7ed36ca) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #33      +/-   ##
==========================================
+ Coverage   96.20%   96.27%   +0.07%     
==========================================
  Files           1        1              
  Lines         158      161       +3     
==========================================
+ Hits          152      155       +3     
  Misses          6        6              
Impacted Files Coverage Δ
src/carbons.c 96.27% <ø> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed36ca...7d73c20. Read the comment docs.

@gkdr gkdr merged commit f299fac into gkdr:dev Dec 25, 2020
@Neustradamus
Copy link

@gkdr: Thanks for merging :)

@shtrom: Can you look the new build?
It is perfect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants