Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built libomemo as a dynamically linked library #30

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

fortysixandtwo
Copy link
Contributor

Hi,

as a part of the DebianOnMobile team I have packaged libomemo [1] (the goal ultimatelly is having lurch in Debian).
The library has been accepted into the unstable branch of Debian.

I changed the Makefile to

  • built a dynamically linked library under the target shared
  • add a pkg-config file similar to how it is done in [2] for axc
  • add a install target
  • add CPPFLAGS to compilation which is used in debian for hardening

[1] https://salsa.debian.org/DebianOnMobile-team/libomemo
[2] gkdr/axc#17

Cheers

PS: Would you be interested in carrying the debian/ folder upstream? If so, I can prepare another pull request

* Makefile: Add new target "shared", "install". Add pkg-config file
@tehnick
Copy link

tehnick commented Jul 4, 2020

The library has been accepted into the unstable branch of Debian.

Great news!

PS: Would you be interested in carrying the debian/ folder upstream? If so, I can prepare another pull request

This is a bad idea. I recommend to not do this.

@fortysixandtwo
Copy link
Contributor Author

fortysixandtwo commented Jul 4, 2020

Thanks for your comment.
Why do you think that it's not a good idea?

@tehnick
Copy link

tehnick commented Jul 4, 2020

Why do you think that it's not a good idea?

You may ask for detailed reply in debian-mentors mailing list. In short: it complicates maintenance of libraries and software in Debian and all its derivatives (Ubuntu, Linux Mint, Raspbian, etc.).

Some useful and laconic information with recommendations for upstream developers you may find at Debian wiki:
https://wiki.debian.org/UpstreamGuide

@fortysixandtwo
Copy link
Contributor Author

I wasn't aware of this particular issue, as some projects I have packaged, already carried such a folder and I've also seen PRs for lurch and carbons adding the debianization.

But it's good to know, thanks!

@gkdr
Copy link
Owner

gkdr commented Jul 13, 2020

Cool, thank you! I'll merge it before the next release. Seems I have to clean up the makefile a bit anyway...

@gkdr gkdr changed the base branch from master to dev December 2, 2020 21:54
@gkdr gkdr merged commit 4b7dd9d into gkdr:dev Dec 2, 2020
@gkdr gkdr mentioned this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants