Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system: defining CFLAGS breaks build #59

Closed
mia-0 opened this issue Jun 21, 2017 · 3 comments
Closed

Build system: defining CFLAGS breaks build #59

mia-0 opened this issue Jun 21, 2017 · 3 comments

Comments

@mia-0
Copy link

mia-0 commented Jun 21, 2017

Linux distributions usually add certain default compiler flags (like -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables).
When trying to package this plugin, I noticed that having CFLAGS defined will override lurch’s own flags, breaking the build.
@gkdr
Copy link
Owner

gkdr commented Jun 25, 2017

Merging #58 would fix this issue, right?

@mia-0
Copy link
Author

mia-0 commented Jun 25, 2017

Looks like it should.

@mia-0 mia-0 mentioned this issue Jul 6, 2017
Closed
@gkdr
Copy link
Owner

gkdr commented Mar 7, 2018

Closing as df33835 merged the references pull request.

@gkdr gkdr closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mia-0 @gkdr