-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexible build for Lurch4Adium #58
Conversation
Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
why does it remove github submodule URLs and changes the .gitmodules to use parent directories? |
Ha, this was to be more flexible: git will resolve submodules based on the URL of the superproject. If lurch is cloned from Making this change made it easier for me to work on the whole codebase in clones from my own GitHub repo without having to fiddle too much. I think it's generally a sane thing to do, but I'm happy to revert to hard-coded URL if desired. |
Finally getting around to doing a few things.
I can't see that it's not being called, so I'm not quite sure what's going on. For now I'm gonna go to bed though. |
|
There was an underscore missing! After also changing the |
Ah. Do you want me to fix the PR, or are you happy to just add a commit on top? |
It's fine, I already fixed it in the local branch I pulled this PR into, and merged everything into the dev branch. Should show up as merged once I merge it into master. |
Make the build more flexible by allowing to override the Makefile variables.
This was needed to support making an Adium plugin in shtrom/Lurch4Adium.
Also fix another few things.