Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible build for Lurch4Adium #58

Merged
merged 9 commits into from
Mar 7, 2018
Merged

Conversation

shtrom
Copy link
Contributor

@shtrom shtrom commented Jun 7, 2017

Make the build more flexible by allowing to override the Makefile variables.

This was needed to support making an Adium plugin in shtrom/Lurch4Adium.

Also fix another few things.

shtrom and others added 9 commits June 8, 2017 21:12
Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
Signed-off-by: Olivier Mehani <shtrom@ssji.net>
@anthraxx
Copy link

why does it remove github submodule URLs and changes the .gitmodules to use parent directories?

@shtrom
Copy link
Contributor Author

shtrom commented Sep 26, 2017

Ha, this was to be more flexible: git will resolve submodules based on the URL of the superproject. If lurch is cloned from github/gkdr/lurch, all submodules will be cloned from there (i.e., github/gkdr/lurch/../SUBMODULE).

Making this change made it easier for me to work on the whole codebase in clones from my own GitHub repo without having to fiddle too much.

I think it's generally a sane thing to do, but I'm happy to revert to hard-coded URL if desired.

@gkdr
Copy link
Owner

gkdr commented Mar 4, 2018

Finally getting around to doing a few things.
Thanks for your porting effort and glad it was not that hard to do. Unfortunately, this doesn't quite work.
You forgot the -fPIC compile flag for lurch itself, and to call pkg-config for sqlite3 and mxml.
After adding those back and getting rid of compilation and linking errors, I still get:

(22:05:22) plugins: /home/riba/.purple/plugins/lurch.so is not usable because the 'purple_init_plugin' symbol could not be found.  Does the plugin call the PURPLE_INIT_PLUGIN() macro?

I can't see that it's not being called, so I'm not quite sure what's going on. For now I'm gonna go to bed though.

@EionRobb
Copy link

EionRobb commented Mar 4, 2018

'purple_init_plugin' symbol could not be found can happen if PURPLE_PLUGINS is not #defined or -Dd

@gkdr
Copy link
Owner

gkdr commented Mar 4, 2018

There was an underscore missing! After also changing the PLUGIN_CPPFLAGS var from -DPURPLEPLUGINS to -DPURPLE_PLUGINS, it compiles and loads fine. Thanks, @EionRobb!

@shtrom
Copy link
Contributor Author

shtrom commented Mar 4, 2018

Ah. Do you want me to fix the PR, or are you happy to just add a commit on top?

@gkdr
Copy link
Owner

gkdr commented Mar 5, 2018

It's fine, I already fixed it in the local branch I pulled this PR into, and merged everything into the dev branch. Should show up as merged once I merge it into master.

@gkdr gkdr merged commit 68e261d into gkdr:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants